Powershell changes #8
Merged
+141
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The choice of bitness depends on the bitness of the OS and 32-bit OSes can run on 64-bit architecture so the check for OS-bitness is more accurate.
The proposed name clarifies what the variable is better.
Originally, opening up a new PowerShell session solved the problem of changes to $env:PATH not taking effect in the current session. However, this can be solved by updating the current session's PATH variable. `Cleanup` is no longer necessary, so the only remaining statement (to remove the downloaded Python MSI) is extracted out. Additionally, this step is performed only if the Python MSI was downloaded.
Installing in the background might obfuscate errors during installation. Through this change, the user will be prompted to click through the MSI GUI.
Although the Python MSI adds Python to PATH, the change will only take effect in a new session. This change adds Python to the current session so that the user does not have to close their terminal.
rahulrajaram
commented
Apr 22, 2019
scripts/install-python.ps1
Outdated
| Update-UserEnvironmentPath | ||
| Remove-Item $PythonInstaller | ||
| } else { | ||
| Write-Host "Python 3.7.3 is already installed. Exiting." -ForegroundColor Green |
Contributor
Author
There was a problem hiding this comment.
" Exiting." is redundant.
jsheld
reviewed
Apr 30, 2019
install-python.ps1
Outdated
| function Download-Python { | ||
| $url = Get-PythonInstallationTarget | ||
| $client = New-Object System.Net.WebClient | ||
| $client.DownloadFile($url, $PythonInstaller) |
Contributor
There was a problem hiding this comment.
If this fails, returning $True doesn't make sense.
Contributor
Author
There was a problem hiding this comment.
Yes, this is eliminate in a future commit.
jsheld
approved these changes
Apr 30, 2019
jsheld
approved these changes
Apr 30, 2019
jsheld
approved these changes
Apr 30, 2019
…value Rename: "Get" is a PowerShell-approved verb, whereas "Assert" is not. This change also modifies the return contract of `Get-PythonExecutable` such that it returns the Python 3.7.3 executables found rather than the indication of whether a Python 3.7.3 executable exists.
When the user exits from the Python MSI prematurely, it returns the exit code 1602.
rahulrajaram
force-pushed
the
PowershellChanges
branch
from
21b4fb4 to
b9a390a
Compare
The PS1 script invokes: - install-python.ps1 - ebcli_installer.py if the Python installer exists with code 0 The PS1 script installs instructs ebcli_installer.py to install `eb` in the user's home directory (within a .ebcli-virtual-env folder). The BAT script wraps the PS1 script.
Future steps may rely on the existence of Python. If Python installation fails, subsequent statements will fail. To preclude subsequent failures, the script will exit immediately following failure to install.
rahulrajaram
force-pushed
the
PowershellChanges
branch
from
b9a390a to
7cb76dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Overview
This PR:
Refer to the independent commit messages for precise details.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
2. Installation Prerequisites
git3. Testing:
Follow installation instructions laid out here.
3.1.
bundled_installer:install-python.ps1) regardless of whether Python is in PATH or notebhas been installed through this means or any other at a prior point if the Python installer returns normally.3.2.
install-python.ps1:virtualenvif Python installation succeeds or is skippedvirtualenveven if it is already in PATHvirtualenvif Python installation failspythonis in the current PowerShell session.pythonis present in the current PowerShell session and the future sessions.3.3.
ebcli_installer.py:Refer to the steps here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.